Add synonym detail page (nasa-gcn#2136)

Closes nasa-gcn#2115.
Courey · Mar 27, 2024 · baefc14 · baefc14
1 parent 16b0806
commit baefc14
Show file tree

Hide file tree

Showing 7 changed files with 380 additions and 191 deletions.
diff --git a/__tests__/synonyms.server.ts b/__tests__/synonyms.server.ts
@@ -6,6 +6,7 @@ import crypto from 'crypto'
 import { createSynonyms, putSynonyms } from '~/routes/synonyms/synonyms.server'
 
 jest.mock('@architect/functions')
+const synonymId = 'abcde-abcde-abcde-abcde-abcde'
 
 describe('createSynonyms', () => {
   beforeAll(() => {
@@ -20,9 +21,7 @@ describe('createSynonyms', () => {
       },
     })
 
-    jest
-      .spyOn(crypto, 'randomUUID')
-      .mockReturnValue('abcde-abcde-abcde-abcde-abcde')
+    jest.spyOn(crypto, 'randomUUID').mockReturnValue(synonymId)
   })
 
   afterAll(() => {
@@ -47,12 +46,13 @@ describe('createSynonyms', () => {
     const synonymousEventIds = ['eventId1', 'eventId2']
     const result = await createSynonyms(synonymousEventIds)
 
-    expect(result).toBe('abcde-abcde-abcde-abcde-abcde')
+    expect(result).toBe(synonymId)
   })
 })
 
 describe('putSynonyms', () => {
   const mockBatchWrite = jest.fn()
+
   beforeAll(() => {
     const mockClient = {
       batchWrite: mockBatchWrite,
@@ -64,9 +64,7 @@ describe('putSynonyms', () => {
       },
     })
 
-    jest
-      .spyOn(crypto, 'randomUUID')
-      .mockReturnValue('abcde-abcde-abcde-abcde-abcde')
+    jest.spyOn(crypto, 'randomUUID').mockReturnValue(synonymId)
   })
 
   afterAll(() => {
@@ -76,40 +74,34 @@ describe('putSynonyms', () => {
   test('putSynonyms should not write to DynamoDB if no additions or subtractions', async () => {
     awsSDKMock.mock('DynamoDB.DocumentClient', 'batchWrite', mockBatchWrite)
 
-    const uuid = 'abcde-abcde-abcde-abcde-abcde'
-
-    await putSynonyms({ uuid })
+    await putSynonyms({ synonymId })
 
     expect(mockBatchWrite).not.toHaveBeenCalled()
   })
 
   test('putSynonyms should write to DynamoDB if there are additions', async () => {
     awsSDKMock.mock('DynamoDB.DocumentClient', 'batchWrite', mockBatchWrite)
-
-    const uuid = 'abcde-abcde-abcde-abcde-abcde'
     const additions = ['eventId1', 'eventId2']
-    await putSynonyms({ uuid, additions })
+    await putSynonyms({ synonymId, additions })
     const params = {
       RequestItems: {
         synonyms: [
-          [
-            {
-              PutRequest: {
-                Item: {
-                  eventId: 'eventId1',
-                  uuid: 'abcde-abcde-abcde-abcde-abcde',
-                },
+          {
+            PutRequest: {
+              Item: {
+                eventId: 'eventId1',
+                synonymId,
               },
             },
-            {
-              PutRequest: {
-                Item: {
-                  eventId: 'eventId2',
-                  uuid: 'abcde-abcde-abcde-abcde-abcde',
-                },
+          },
+          {
+            PutRequest: {
+              Item: {
+                eventId: 'eventId2',
+                synonymId,
               },
             },
-          ],
+          },
         ],
       },
     }
@@ -119,31 +111,14 @@ describe('putSynonyms', () => {
   test('putSynonyms should write to DynamoDB if there are subtractions', async () => {
     awsSDKMock.mock('DynamoDB.DocumentClient', 'batchWrite', mockBatchWrite)
 
-    const uuid = 'abcde-abcde-abcde-abcde-abcde'
     const subtractions = ['eventId3', 'eventId4']
 
-    await putSynonyms({ uuid, subtractions })
+    await putSynonyms({ synonymId, subtractions })
     const params = {
       RequestItems: {
         synonyms: [
-          [
-            {
-              DeleteRequest: {
-                Key: {
-                  eventId: 'eventId3',
-                  uuid: 'abcde-abcde-abcde-abcde-abcde',
-                },
-              },
-            },
-            {
-              DeleteRequest: {
-                Key: {
-                  eventId: 'eventId4',
-                  uuid: 'abcde-abcde-abcde-abcde-abcde',
-                },
-              },
-            },
-          ],
+          { DeleteRequest: { Key: { eventId: 'eventId3' } } },
+          { DeleteRequest: { Key: { eventId: 'eventId4' } } },
         ],
       },
     }
@@ -153,51 +128,44 @@ describe('putSynonyms', () => {
   test('putSynonyms should write to DynamoDB if there are additions and subtractions', async () => {
     awsSDKMock.mock('DynamoDB.DocumentClient', 'batchWrite', mockBatchWrite)
 
-    const uuid = 'abcde-abcde-abcde-abcde-abcde'
     const additions = ['eventId1', 'eventId2']
     const subtractions = ['eventId3', 'eventId4']
 
-    await putSynonyms({ uuid, additions, subtractions })
+    await putSynonyms({ synonymId, additions, subtractions })
 
     const params = {
       RequestItems: {
         synonyms: [
-          [
-            {
-              DeleteRequest: {
-                Key: {
-                  eventId: 'eventId3',
-                  uuid: 'abcde-abcde-abcde-abcde-abcde',
-                },
+          {
+            DeleteRequest: {
+              Key: {
+                eventId: 'eventId3',
               },
             },
-            {
-              DeleteRequest: {
-                Key: {
-                  eventId: 'eventId4',
-                  uuid: 'abcde-abcde-abcde-abcde-abcde',
-                },
+          },
+          {
+            DeleteRequest: {
+              Key: {
+                eventId: 'eventId4',
               },
             },
-          ],
-          [
-            {
-              PutRequest: {
-                Item: {
-                  eventId: 'eventId1',
-                  uuid: 'abcde-abcde-abcde-abcde-abcde',
-                },
+          },
+          {
+            PutRequest: {
+              Item: {
+                eventId: 'eventId1',
+                synonymId,
               },
             },
-            {
-              PutRequest: {
-                Item: {
-                  eventId: 'eventId2',
-                  uuid: 'abcde-abcde-abcde-abcde-abcde',
-                },
+          },
+          {
+            PutRequest: {
+              Item: {
+                eventId: 'eventId2',
+                synonymId,
               },
             },
-          ],
+          },
         ],
       },
     }

diff --git a/app.arc b/app.arc
@@ -140,7 +140,7 @@ legacy_users
   name legacyAnnouncementReceivers
 
 synonyms
-  uuid *String
+  synonymId *String
   name synonymsByUuid
 
 @aws