changes in response to review

Courey · Nov 30, 2023 · e2b8b4f · e2b8b4f
1 parent 34ae978
commit e2b8b4f
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 19 deletions.
diff --git a/app.arc b/app.arc
@@ -121,7 +121,7 @@ circulars
 
 circulars
   eventId *String
-  name circularEventId
+  name circularsByEventId
 
 circulars_subscriptions
   sub *String

diff --git a/app/routes/_gcn.synonyms/synonyms.lib.ts b/app/routes/_gcn.synonyms/synonyms.lib.ts
@@ -1,10 +1,10 @@
-// /*!
-//  * Copyright © 2023 United States Government as represented by the
-//  * Administrator of the National Aeronautics and Space Administration.
-//  * All Rights Reserved.
-//  *
-//  * SPDX-License-Identifier: Apache-2.0
-//  */
+/*!
+ * Copyright © 2023 United States Government as represented by the
+ * Administrator of the National Aeronautics and Space Administration.
+ * All Rights Reserved.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
 export interface Synonym {
   eventId: string
   synonymId: string

diff --git a/sandbox-search.js b/sandbox-search.js
@@ -9,15 +9,16 @@ import { readFile } from 'fs/promises'
 
 export default async function () {
   const text = await readFile('sandbox-seed.json', { encoding: 'utf-8' })
-  const { circulars } = JSON.parse(text)
-  const { synonyms } = JSON.parse(text)
-  const circularResults = circulars.flatMap((item) => [
-    { index: { _index: 'circulars', _id: item.circularId.toString() } },
-    item,
-  ])
-  const groupResults = synonyms.flatMap((item) => [
-    { index: { _index: 'synonyms', _id: item.id } },
-    item,
-  ])
-  return circularResults.concat(groupResults)
+  const { circulars, synonyms } = JSON.parse(text)
+
+  return [
+    ...circulars.flatMap((item) => [
+      { index: { _index: 'circulars', _id: item.circularId.toString() } },
+      item,
+    ]),
+    ...synonyms.flatMap((item) => [
+      { index: { _index: 'synonyms', _id: item.id } },
+      item,
+    ]),
+  ]
 }