First half of forum unread logic #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowjoel
force-pushed
the
lowjoel/forum-unread
branch
2 times, most recently
from
34f559e to
238c5bd
Compare
This is needed to ensure that the unread flags are properly set.
lowjoel
force-pushed
the
lowjoel/forum-unread
branch
from
238c5bd to
83bfba8
Compare
| @@ -1,11 +1,16 @@ | |||
| = div_for(post, class: ['post']) do | |||
| - post_class = ['post'] | |||
| - post_class << 'unread' if post.unread?(current_user) | |||
There was a problem hiding this comment.
Better put this inside a helper ?
lowjoel
force-pushed
the
lowjoel/forum-unread
branch
from
83bfba8 to
66d6151
Compare
|
@lowjoel Build failed |
|
@allenwq random failure, it passes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks posts and topics as read when visiting. Computing the number of unread topics will be in the following PR, pending merge of aha-app/calculated_attributes#11.