Update dependencies and add env variables to get repo working on Heroku #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prototriangle
commented
Oct 27, 2018
•
prototriangle
commented
- Edits were tested on Heroku.
- Used a newly created MyMLH application for testing.
- Updated scheme of mlh sign-in callback to use https (perhaps this should be removed)
|
(Probably should squash) |
prototriangle
changed the title
|
Once merged, I'll set up a Heroku app that will automatically update from |
notexactlyawe
requested changes
Oct 28, 2018
| @@ -1,6 +1,6 @@ | |||
| # Cog | |||
|
|
|||
| [](https://heroku.com/deploy?template=https://github.com/CreatEDHack/cog) | |||
| [](https://heroku.com/deploy?template=https://github.com/prototriangle/cog) | |||
There was a problem hiding this comment.
This should probably stay as CreatEDHack if this is being merged into CreatEDHack
| @@ -38,7 +38,7 @@ an additional account. | |||
| The easiest way to deploy Cog is to smash this Deploy to Heroku button right | |||
| here: | |||
|
|
|||
| [](https://heroku.com/deploy?template=https://github.com/techx/cog) | |||
| [](https://heroku.com/deploy?template=https://github.com/prototriangle/cog) | |||
| @@ -1,8 +1,14 @@ | |||
| { | |||
| "name": "Cog", | |||
| "description": "A hackathon hardware check-out system by HackMIT", | |||
| "repository": "https://github.com/techx/cog", | |||
| "repository": "https://github.com/prototriangle/cog", | |||
| "env": { | ||
| "OAUTH_ID": { |
There was a problem hiding this comment.
If I remember these were environment variables before. What is the behaviour of the app now that these are in app.json? What does this change? Are the docs updated?
| @@ -9,7 +9,7 @@ cffi==1.10.0 | |||
| chardet==3.0.4 | |||
| click==6.7 | |||
| configparser==3.5.0 | |||
| cryptography==1.7.2 | |||
| cryptography==2.3.1 | |||
There was a problem hiding this comment.
It would be nice to see a test (or just a reasoned argument) that confirmed this change didn't break the app
There was a problem hiding this comment.
Also, linking in #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.