Merge pull request #11 from mraible/github-actions

CrowdStrike · Sep 26, 2024 · eeb01c1 · eeb01c1
2 parents 1d4cbc3 + b200bb2
commit eeb01c1
Show file tree

Hide file tree

Showing 12 changed files with 6,516 additions and 4,215 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -0,0 +1,36 @@
+name: Sample CI
+on: [ push, pull_request ]
+
+jobs:
+  build:
+    strategy:
+      matrix:
+        path:
+          - shared/mitre-vue
+          - ui/extensions/remediations
+          - ui/pages/chart-vue
+    name: Build and Test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Use Node 20
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: 'yarn'
+      - name: Run yarn install in ${{ matrix.path }}
+        uses: borales/actions-yarn@v5
+        with:
+          cmd: install
+          dir: ${{ matrix.path }}
+      - name: Build Vue app in ${{ matrix.path }}
+        if: matrix.path != 'shared/mitre-vue'
+        uses: borales/actions-yarn@v5
+        with:
+          cmd: build
+          dir: ${{ matrix.path }}
+      - name: Test the Vue app in ${{ matrix.path }}
+        uses: borales/actions-yarn@v5
+        with:
+          cmd: test:unit
+          dir: ${{ matrix.path }}
diff --git a/.gitignore b/.gitignore
@@ -1,6 +1,7 @@
-.idea
-node_modules
-.idea
+.idea/
+node_modules/
 .DS_Store
 .vscode
-yarn-error.log
+yarn-error.log
+.yarnrc.yml
+.yarn/
diff --git a/shared/mitre-vue/package.json b/shared/mitre-vue/package.json
@@ -31,11 +31,11 @@
   },
   "dependencies": {
     "@crowdstrike/foundry-js": "0.10.0",
+    "@intlify/unplugin-vue-i18n": "^1.2.0",
     "@shoelace-style/shoelace": "^2.8.0",
     "pinia": "^2.1.3",
     "vue": "^3.3.4",
-    "vue-i18n": "^9.3.0-beta.14-77e850b",
-    "@intlify/unplugin-vue-i18n": "^1.2.0"
+    "vue-i18n": "^9.3.0-beta.14-77e850b"
   },
   "devDependencies": {
     "@rushstack/eslint-patch": "^1.2.0",

diff --git a/shared/mitre-vue/tests/utils/transformData.test.ts b/shared/mitre-vue/tests/utils/transformData.test.ts
@@ -32,8 +32,7 @@ describe('Unit test - transformData.ts', () => {
             false,
             false
         )
-
-
+
         result.map((tactic) => {
             const listOfTechniques = tactic.techniques.map(t => t.technique_id);
 
@@ -124,7 +123,7 @@ describe('Unit test - transformData.ts', () => {
         const from = new Date();
         from.setDate(to.getDate() - 91)
         const calculatedTrend = calculateTrend(exampleTrendData as TrendAggregate, from, to)
-        expect(calculatedTrend).toBe(1)
+        expect(calculatedTrend).toBe(-1)
     })
 
     it('Should calculate trend a 100% decrease', () => {
@@ -215,9 +214,9 @@ describe('Unit test - transformData.ts', () => {
 
                     expect(foundSubTechnique?.is_subtechnique).toBeTruthy()
 
-                    
+
                     const severityDetails = Object.values(foundSubTechnique?.severity_details)
-                    
+
                     technique?.sub_aggregates?.find(t => t.name === 'Severity')?.buckets.map((severity) =>{
                         expect(severityDetails.includes(severity.count)).toBeTruthy()
                     })

diff --git a/ui/extensions/remediations/package.json b/ui/extensions/remediations/package.json
@@ -17,11 +17,11 @@
   "dependencies": {
     "@crowdstrike/foundry-js": "0.10.0",
     "@intlify/unplugin-vue-i18n": "^0.12.3",
+    "@mitre/vue-shared": "*",
     "@shoelace-style/shoelace": "^2.8.0",
     "pinia": "^2.1.3",
     "vue": "^3.3.4",
-    "vue-i18n": "^9.3.0-beta.14-77e850b",
-    "@mitre/vue-shared": "*"
+    "vue-i18n": "^9.3.0-beta.14-77e850b"
   },
   "devDependencies": {
     "@modyfi/vite-plugin-yaml": "^1.0.4",
@@ -54,5 +54,5 @@
   },
   "engines": {
     "node": ">=18.12.0"
-  } 
+  }
 }
diff --git a/ui/extensions/remediations/src/stores/extension.ts b/ui/extensions/remediations/src/stores/extension.ts
@@ -3,11 +3,7 @@
  */
 import type FalconApi from '@crowdstrike/foundry-js'
 import type { I18NComposer } from '@mitre/vue-shared/plugins/i18n'
-import type {
-  DetectionItem,
-  JiraPriorityItem,
-  NotifyConfig
-} from '@mitre/vue-shared/types'
+import type { DetectionItem, JiraPriorityItem, NotifyConfig } from '@mitre/vue-shared/types'
 import {
   getCreatedIssue,
   getNotifyIRConfig,

diff --git a/ui/pages/chart-vue/package.json b/ui/pages/chart-vue/package.json
@@ -17,12 +17,12 @@
   "dependencies": {
     "@crowdstrike/foundry-js": "0.10.0",
     "@intlify/unplugin-vue-i18n": "^0.12.3",
+    "@mitre/vue-shared": "*",
     "@shoelace-style/shoelace": "^2.8.0",
     "pinia": "^2.1.3",
     "vue": "^3.3.4",
     "vue-i18n": "^9.3.0-beta.14-77e850b",
-    "vue-router": "^4.2.2",
-    "@mitre/vue-shared": "*"
+    "vue-router": "^4.2.2"
   },
   "devDependencies": {
     "@modyfi/vite-plugin-yaml": "^1.0.4",

diff --git a/ui/pages/chart-vue/src/components/MatrixChart/ChartHeader/ActionsButton.vue b/ui/pages/chart-vue/src/components/MatrixChart/ChartHeader/ActionsButton.vue
@@ -4,10 +4,7 @@
  */
 import { useConfigureJiraStore } from '@/stores/configure-jira'
 import type FalconApi from '@crowdstrike/foundry-js'
-import {
-  DotsMenuClosed24Component,
-  DotsMenuOpen24Component
-} from '@mitre/vue-shared/icons'
+import { DotsMenuClosed24Component, DotsMenuOpen24Component } from '@mitre/vue-shared/icons'
 import type { I18NComposer } from '@mitre/vue-shared/plugins/i18n'
 import SYMBOLS from '@mitre/vue-shared/utils/symbols'
 import { inject, ref } from 'vue'

diff --git a/ui/pages/chart-vue/src/components/MatrixChart/DetectionsNumber.vue b/ui/pages/chart-vue/src/components/MatrixChart/DetectionsNumber.vue
@@ -2,10 +2,7 @@
 /**
  * Formatted detections number (compact format after 9999)
  */
-import {
-  MitreDetectionFilledIcon,
-  MitreDetectionOutlinedIcon
-} from '@mitre/vue-shared/icons'
+import { MitreDetectionFilledIcon, MitreDetectionOutlinedIcon } from '@mitre/vue-shared/icons'
 import type { I18NComposer } from '@mitre/vue-shared/plugins/i18n'
 import SYMBOLS from '@mitre/vue-shared/utils/symbols'
 import { computed, inject } from 'vue'

diff --git a/ui/pages/chart-vue/src/components/MatrixChart/InfoPanel/TechniqueDetections.vue b/ui/pages/chart-vue/src/components/MatrixChart/InfoPanel/TechniqueDetections.vue
@@ -2,11 +2,7 @@
 /**
  * Technique Detections Component
  */
-import {
-  ActivityIcon,
-  ExternalLink16Icon,
-  MitreDetectionFilledIcon
-} from '@mitre/vue-shared/icons'
+import { ActivityIcon, ExternalLink16Icon, MitreDetectionFilledIcon } from '@mitre/vue-shared/icons'
 import type { I18NComposer } from '@mitre/vue-shared/plugins/i18n'
 import SYMBOLS from '@mitre/vue-shared/utils/symbols'
 import { type SeverityDetail } from '@mitre/vue-shared/types'

diff --git a/ui/pages/chart-vue/src/stores/matrix-chart.ts b/ui/pages/chart-vue/src/stores/matrix-chart.ts
@@ -183,10 +183,7 @@ export const useMatrixChartStore = defineStore('matrix-chart', () => {
             showSubtechniques.value
           )
 
-          const sortedTactics = reorderItems(
-            rawTactics,
-            showSubtechniques.value
-          )
+          const sortedTactics = reorderItems(rawTactics, showSubtechniques.value)
 
           tactics.value = sortedTactics
           setTechniqueMapping(tactics.value)