[EP-2362] Deduplicate sign in modals #1132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to look at the sign in link on AEM to see if we need to change it with this change. |
As I was reading your code, I see that we won't need to as you have kept the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the sign in modal could be opened from the session modal directly or from the register account modal inside of the session modal. The main difference was that the direct sign in modal didn't have the "Welcome back!" header/sidebar.
This PR removes the sign in modal from the session modal so that it will always be displayed inside of the register account modal. I added the
minimalbinding that when set to true hides the Welcome back header/sidebar.I also cleaned up the bindings of signInModal so that no longer directly changes the state of the parent modal.