Feat:minors algorithm for the MREstimator #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloydZ
reviewed
Jan 22, 2024
|
|
||
|
|
||
| class Minors(MRAlgorithm): | ||
| r""" |
| return self._get_optimal_parameter(MR_NUMBER_OF_COEFFICIENTS_TO_GUESS) | ||
|
|
||
| def _ME_time_complexity_helper_(self, m, n_reduced, k_reduced, r): | ||
| time = 0 |
There was a problem hiding this comment.
the only difference between _ME_time_complexity_helper and _ME_memory_complexity_helper is w* and 2*. So maybe we can merge those two into one function, to reduce code complexity.
|
@Javierverbel PR updated. Please approve if it is fine with you. |
…m:Crypto-TII/CryptographicEstimators into feature/add_minors_algorithm_mr_estimator
|
FloydZ
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description