Show "400 Missing slash" when needed Rob--W#238

Cryptwire · Mar 22, 2021 · 34ec83b · 34ec83b
1 parent 207e1e9
commit 34ec83b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/cors-anywhere.js b/lib/cors-anywhere.js
@@ -316,6 +316,14 @@ function getHandler(options, proxy) {
     }
 
     if (!location) {
+      // Special case http:/notenoughslashes, because new users of the library frequently make the
+      // mistake of putting this application behind a server/router that normalizes the URL.
+      // See https://github.com/Rob--W/cors-anywhere/issues/238#issuecomment-629638853
+      if (/^\/https?:\/[^/]/i.test(req.url)) {
+        res.writeHead(400, 'Missing slash', cors_headers);
+        res.end('The URL is invalid: two slashes are needed after the http(s):.');
+        return;
+      }
       // Invalid API call. Show how to correctly use the API
       showUsage(corsAnywhere.helpFile, cors_headers, res);
       return;

diff --git a/test/test.js b/test/test.js
@@ -141,7 +141,7 @@ describe('Basic functionality', function() {
     request(cors_anywhere)
       .get('/http:/notenoughslashes')
       .expect('Access-Control-Allow-Origin', '*')
-      .expect(200, helpText, done);
+      .expect(400, 'The URL is invalid: two slashes are needed after the http(s):.', done);
   });