CI: add cargo hack #170
CI: add cargo hack #170
Conversation
github-actions
bot
added
A-p2p
github-actions
bot
added
A-workspace
Co-authored-by: hinto-janai <[email protected]>
github-actions
bot
added
A-consensus
| fn compress_integer_array(_: &[u64]) -> error::Result<Vec<u8>> { | ||
| #[cfg(any(feature = "epee", feature = "serde"))] | ||
| fn compress_integer_array(_: &[u64]) -> Vec<u8> { |
There was a problem hiding this comment.
Why was this signature changed? It can error because it uses https://doc.cuprate.org/cuprate_epee_encoding/fn.write_varint.html.
There was a problem hiding this comment.
No this uses a different varint format: #229 (comment)
| proptest = ["dep:proptest", "dep:proptest-derive"] | ||
| json = ["hex", "dep:cuprate-helper"] | ||
| hex = ["dep:hex"] | ||
| # We sadly have no choice but to enable serde here as otherwise we will get warnings from the `hex` dep being unused. |
There was a problem hiding this comment.
I'm not sure if this is exactly right but would something like this work?
#[cfg(all(feature = "hex", feature = "serde"))]
use hex as _;There was a problem hiding this comment.
It would but IMO just enabling serde here is better as the enabled type literally only makes sense with serde
|
Btw merging this can close #325 I think? |
| # default = ["redb", "service"] | ||
| # default = ["redb-memory", "service"] | ||
| heed = ["cuprate-database/heed"] | ||
| redb = ["cuprate-database/redb"] | ||
| redb-memory = ["cuprate-database/redb-memory"] | ||
| service = ["dep:tower", "dep:rayon", "dep:cuprate-database-service"] |
There was a problem hiding this comment.
Why was this feature was removed? Should cuprate-blockchain do the same?
Anyway some docs should be updated:
There was a problem hiding this comment.
Because it was annoying to get this to pass CI so I just removed the feature, almost all use cases will use the tower interface anyway, for those that don't I don't think a few extra dependencies would be too bad.
I for parity removed the feature flag from cuprate-blockchain as well and updated the docs
github-actions
bot
added
A-binaries
adds cargo hack to CI and fixes errors found.