Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RenderOffsets #116

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

dadodasyra
Copy link

This may (and will) lead to API BC
Fixes #114

This may (and will) lead to API BC
@unickorn
Copy link
Member

Hey @dadodasyra, was this tested? Can we get a before/after?

@dadodasyra
Copy link
Author

I use it on my fork (HisteriaMC/Customies) since multiple month now for my server and I don't have any issue with it. It was a asked change from my community because the old ones looks weird.
I don't really have any test plugin/dev environment to try it on the official code and I don't really have the time to do it so... I will tell some developer friends to test it that I know use customies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RenderOffset could be better
3 participants