Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempt to silence a recent ubsan warning with code reorganization #1004

Merged
merged 2 commits into from
Jan 22, 2025
Merged

attempt to silence a recent ubsan warning with code reorganization #1004

merged 2 commits into from
Jan 22, 2025

Conversation

Cyan4973
Copy link
Owner

apparently, UBSAN uses the prototype of the inner inlined function instead of the outer shell of the function.
Let's see if one indirection level is enough to fix this.

@Cyan4973 Cyan4973 self-assigned this Jan 21, 2025
@Cyan4973
attempt to silence a recent ubsan warning with code reorganization
c3e587a 
apparently, UBSAN uses the prototype of the inner inlined function
instead of the outer shell of the function.
Let's see if one indirection level is enough to fix this.
@Cyan4973
Copy link
Owner Author

OK, so clang's ubsan has become sensible to noescape attribute and now complains when there is any difference.

@Cyan4973
Copy link
Owner Author

OK, all tests fixed, CI signal is green.
Let's fix the other PRs by rebasing on top of this one.

@Cyan4973 Cyan4973 merged commit f5a0b6f into dev Jan 22, 2025
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Cyan4973 Cyan4973

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Cyan4973