LIBXXH_DISPATCH: control runtime vector dispatch in libxxhash
#987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DISPATCH disabled by default (in contrast with `DISPATCH`, which is enabled by default, for `xxhsum`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new build variable is disabled by default.
This is in contrast with
DISPATCH, which is enabled by default (forxxhsum).At this stage, it's not yet clear if this is a good idea to enable this parameter by default.
It adds a lot of new public symbols to the dynamic library,
and accessing them is supposed to be controlled through the separate header
xxh_x86dispatch.h,so this capability is not exactly transparent
and anyway it's unclear if this is good idea for this capability to be transparent.
Likely to be discussed again later.