Skip to content

Commit

Permalink
Close a security hole that was causing the permission to not be enfor…
Browse files Browse the repository at this point in the history
…ced on request broadcast intents.
  • Loading branch information
ChainsDD authored and hyperb1iss committed Aug 20, 2010
1 parent d80baf8 commit 467d248
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions su/activity.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ int send_intent(struct su_initiator *from, struct su_request *to, const char *so
data.writeInt32(-1); /* resultCode */
data.writeString16(NULL, 0); /* resultData */

data.writeInt32(-1); /* somewhere between these two lines is resultExtras */
data.writeInt32(-1); /* not sure which line it is, but they both need to be here*/
data.writeInt32(-1); /* resultExtras */

data.writeString16(String16("com.noshufou.android.su.RESPOND")); /* perm */
data.writeInt32(0); /* serialized */
Expand Down

0 comments on commit 467d248

Please sign in to comment.