Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor signature validation logic to discord-interactions-js #241

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Refactor signature validation logic to discord-interactions-js #241

merged 2 commits into from
Jun 18, 2024

Conversation

CyberFlameGO
Copy link
Owner

@CyberFlameGO CyberFlameGO commented Jun 18, 2024 •
edited
Loading

Why:

Closes #240

What's being changed:

  • Remove discord-verify
  • Refactor code to utilise already-present discord-interactions-js library
  • [ ] Refactor ping command for increased accuracy

Out of scope but tolerable

  • Dependency updates

Check off the following:

  • I have reviewed my changes to make sure they don't break intended functionality (i.e. nothing is negatively impacted/affected, everything works as intended)

@CyberFlameGO CyberFlameGO added enhancement New feature or request javascript Pull requests that update Javascript code dependencies Pull requests that update a dependency file labels Jun 18, 2024
@CyberFlameGO CyberFlameGO self-assigned this Jun 18, 2024
@CyberFlameGO CyberFlameGO marked this pull request as draft June 18, 2024 10:47
@CyberFlameGO CyberFlameGO marked this pull request as ready for review June 18, 2024 11:46
@CyberFlameGO CyberFlameGO merged commit d7bedae into main Jun 18, 2024
5 checks passed
@CyberFlameGO CyberFlameGO deleted the refactor/revert-to-older-message-verification branch June 18, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CyberFlameGO CyberFlameGO

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request javascript Pull requests that update Javascript code
Projects
NCEAHelpWorker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency on discord-verify; revert to discord-interactions-js
1 participant
@CyberFlameGO