Upgrade firebase/php-jwt v6 #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it planned to be merged soon? |
|
What is blocking this from getting merged? |
|
version of "firebase/php-jwt" upgraded to ^6.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #119
Upgrading firebase/php-jwt to v6 because v5 is vulnerable GHSA-8xf4-w7qw-pjjw
Here are the Backwards Compatibility Breaking Changes : https://github.com/firebase/php-jwt/releases/tag/v6.0.0
The cybersource SDK itself isn't vulnerable because you are providing the
$algparam when callingJWT::encode(), but it forces the version 5 on the whole project, and that may be a security problem for project depending on your lib.I didnt manage to run phpunit tests on my local env, do you have any CI configured somewhere ?