Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new implementation cyclonedx bom #532

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

gordonrousselle
Copy link

@gordonrousselle gordonrousselle commented Oct 27, 2024

This is a proposal implementation for the next major version of the cyclonedx gradle plugin. The reason for this is twofold. Firstly, this implementation will support Gradle's configuration cache which will be enforced by default in the near future. Secondly, it aims to resolve some of the open issues reported against the current implementation.

Most of the existing features are still supported, but a couple of points are worth noting:

  • child projects, if exists, are now also included as component in the resulting BOM
  • component that represent gradle projects have purls without a type field (defaulted to JAR in previous version)
  • Version 1.0 of the CycloneDX BOM is not supported anymore

@gordonrousselle gordonrousselle force-pushed the feat/new-implementation-cyclonedxBom branch from 487c48f to e016f01 Compare October 28, 2024 11:51
@skhokhlov skhokhlov added this to the 2.0.0 milestone Oct 28, 2024
@skhokhlov
Copy link
Member

I think this PR should resolve #528, @gordonrousselle can you please add test for it?

@skhokhlov skhokhlov marked this pull request as draft November 1, 2024 22:15
…date sbom, missing nullables and remove duplicated code

Signed-off-by: Gordon <[email protected]>
@gordonrousselle gordonrousselle force-pushed the feat/new-implementation-cyclonedxBom branch from f235111 to be08c09 Compare November 11, 2024 19:39
…ackage:projectsAndScopes properties (adding back in later PR)

Signed-off-by: Gordon <[email protected]>
@skhokhlov skhokhlov marked this pull request as ready for review November 13, 2024 15:16
@skhokhlov skhokhlov force-pushed the feat/new-implementation-cyclonedxBom branch from a2c603f to 7a81820 Compare November 13, 2024 15:20
@jkowalleck jkowalleck requested a review from a team November 13, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle configurations not being merged, resulting bom is made by a single random configuration
2 participants