-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/new implementation cyclonedx bom #532
Open
gordonrousselle
wants to merge
26
commits into
CycloneDX:master
Choose a base branch
from
gordonrousselle:feat/new-implementation-cyclonedxBom
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/new implementation cyclonedx bom #532
gordonrousselle
wants to merge
26
commits into
CycloneDX:master
from
gordonrousselle:feat/new-implementation-cyclonedxBom
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 28, 2024
Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
…for non existing file extensions Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
gordonrousselle
force-pushed
the
feat/new-implementation-cyclonedxBom
branch
from
October 28, 2024 11:51
487c48f
to
e016f01
Compare
I think this PR should resolve #528, @gordonrousselle can you please add test for it? |
Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
skhokhlov
reviewed
Nov 4, 2024
src/main/java/org/cyclonedx/gradle/DependencyGraphTraverser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cyclonedx/gradle/DependencyGraphTraverser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cyclonedx/gradle/DependencyGraphTraverser.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gordon <[email protected]>
skhokhlov
requested changes
Nov 5, 2024
…date sbom, missing nullables and remove duplicated code Signed-off-by: Gordon <[email protected]>
gordonrousselle
force-pushed
the
feat/new-implementation-cyclonedxBom
branch
from
November 11, 2024 19:39
f235111
to
be08c09
Compare
…ackage:projectsAndScopes properties (adding back in later PR) Signed-off-by: Gordon <[email protected]>
…ovider package private Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
…for non existing file extensions Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
Signed-off-by: Gordon <[email protected]>
…date sbom, missing nullables and remove duplicated code Signed-off-by: Gordon <[email protected]>
…ackage:projectsAndScopes properties (adding back in later PR) Signed-off-by: Gordon <[email protected]>
…ovider package private Signed-off-by: Gordon <[email protected]>
skhokhlov
force-pushed
the
feat/new-implementation-cyclonedxBom
branch
from
November 13, 2024 15:20
a2c603f
to
7a81820
Compare
….com/gordonrousselle/cyclonedx-gradle-plugin into feat/new-implementation-cyclonedxBom
Signed-off-by: Gordon <[email protected]>
skhokhlov
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal implementation for the next major version of the cyclonedx gradle plugin. The reason for this is twofold. Firstly, this implementation will support Gradle's configuration cache which will be enforced by default in the near future. Secondly, it aims to resolve some of the open issues reported against the current implementation.
Most of the existing features are still supported, but a couple of points are worth noting: