Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(poetry): properly handle multi-declaration (optional) dependencies #842

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jan 21, 2025

fixes #840

Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck added bug Something isn't working source: poetry labels Jan 21, 2025
@jkowalleck jkowalleck requested a review from a team as a code owner January 21, 2025 11:56
Copy link

codacy-production bot commented Jan 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3a50f8d) 1092 1055 96.61%
Head commit (704b208) 1095 (+3) 1058 (+3) 96.62% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#842) 7 7 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck jkowalleck changed the title fix(poetry): optional dependencies w/o extra are not installed fix(poetry): properly detect optional dependencies declared as list Jan 21, 2025
@jkowalleck jkowalleck changed the title fix(poetry): properly detect optional dependencies declared as list fix(poetry): properly handle multi-constraint declarations Jan 21, 2025
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck changed the title fix(poetry): properly handle multi-constraint declarations fix(poetry): properly handle multi-declarations Jan 21, 2025
@jkowalleck jkowalleck changed the title fix(poetry): properly handle multi-declarations fix(poetry): properly handle multi-declaration (optional) dependencies Jan 21, 2025
@jkowalleck jkowalleck merged commit 18c5f0e into main Jan 21, 2025
37 checks passed
@jkowalleck jkowalleck deleted the fix/poetry-corner-braced-dependencies branch January 21, 2025 13:55
@jkowalleck
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working source: poetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] multi-declare (optional) dependencies are treated as root dependencies
1 participant