Put cw-vesting staking features behind a feature flag #800
+48
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #800 +/- ##
==============================================
Coverage ? 96.17%
==============================================
Files ? 207
Lines ? 53401
Branches ? 0
==============================================
Hits ? 51359
Misses ? 2042
Partials ? 0 ☔ View full report in Codecov by Sentry. |
bekauz
approved these changes
Feb 6, 2024
NoahSaso
force-pushed
the
noah/support-vesting-non-staking
branch
2 times, most recently
from
acfc547 to
aaebfdf
Compare
NoahSaso
force-pushed
the
noah/support-vesting-non-staking
branch
from
aaebfdf to
59d59a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neutron does not support the staking module, and the
cw-vestingcontract attempts to execute a staking-related message on instantiate for the native token. This means that the vesting contract does not currently work for NTRN on Neutron.This PR adds a
stakingfeature flag tocw-vestingthat explicitly enables the execution variants that have to do with staking, in addition to the withdraw address message on instantiate.