Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full extraction with ms3 v2.4.1, including chords facet; added pre-commit hook (workflow v4.3) #70

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

johentsch
Copy link
Member

Added chords facet

Not to be confounded with labels or chord annotations, a chord is a notational unit in which all included notes are part of the same notational layer and have the same onset and duration. Every chord has a chord_id and every note is part of a chord. These tables are used to convey score information that is not attached to a particular note, such as lyrics, staff text, dynamics and other markup. More information on the columns can be found in the documentation of the ms3 parser.

Added pre-commit hook

The new iteration of the DCML annotation workflow moves the automatic validation of scores and annotations from GitHub actions to the local user. Whenever you are planning to commit changes to the annotation labels, you may want to install the pre-commit package to then run pre-commit install in your local clone. From this moment on, each time you try to commit changes to one or several MuseScore files, the hook will run ms3 review on them and will reject the commit if warnings are detected. If no warnings are detected, the commit will be enriched with all updates to the repo's TSV files that reflect the changes you've made to the scores.

@johentsch johentsch merged commit 33785b1 into main Dec 5, 2023
@johentsch johentsch deleted the with_chords branch December 5, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant