Use OpenSSL and ZLIB targets to link against #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These patchs are interesting and allow to further deploy dcmtk without hard-coded path related to the build machine. |
CMake/DCMTKConfig.cmake.in
Outdated
| # Depend packages | ||
| if(DCMTK_WITH_ZLIB) | ||
| if(NOT ZLIB_FOUND) | ||
| find_package(ZLIB) |
There was a problem hiding this comment.
You should use find_dependency here for better error handling.
https://stackoverflow.com/questions/50263280/difference-between-find-dependency-and-find-package-in-cmake
There was a problem hiding this comment.
thanks, did not know about this one yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both libraries are binary compatible between versions so there is no need to depend on specific build paths of them. If available their targets should be preferred.