Adjust source fields: holding_institution, name, production_method, source_completeness #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchiller
changed the title
dchiller
changed the title
dchiller
force-pushed
the
i1628-source-printed
branch
from
0fcaaa2
to
d520337
Compare
|
The failing test will be fixed with the merge of #1643 -- once that is reviewed and merged I'll fix this. |
ahankinson
reviewed
Oct 3, 2024
ahankinson
reviewed
Oct 3, 2024
ahankinson
reviewed
Oct 3, 2024
Updates source create, source edit, and source detail pages. Adds command to populate the `source_completeness` field based on the current contents of the `full_source` field (which can be deleted after this field is populated).
Removes the need to duplicate process of using default SelectWidget on ChoiceFields and then manually changing attributes.
This commit removes the requirement for a source to have a holding_institution. Tests and forms are updated to account for this. The `migrate_records` command is updated so that sources with un-parseable sigla that are not otherwise accounted for (by virtue of being private collections or prints) do not have institution records made. Note: For the purposes of data migration, no constraint is added to sources to designate when no holding institution is necessary. After migration, these should be modified. Refs: DDMAL#1631
dchiller
force-pushed
the
i1628-source-printed
branch
from
d520337
to
065ef07
Compare
|
Tests are now passing. Have not heard back confirmation on some of the remaining formatting questions, so holding for the moment. |
|
Ok, after discussing the remaining questions with Anna, Debra, and Jennifer:
|
|
@lucasmarchd01 this is ready for you now |
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR removes some previously-committed migrations. You will need to re-create your local/staging database to do development after this PR is merged. I decided to do this because it will make the update of production go smoother (ie. not have to run to a certain migration, then run the migrate_records command, then apply the rest of the migrations), which ultimately felt preferable to prioritizing people's individual current development database status.
Makes significant changes to the
Sourcemodel:Sourceto have aholding_institution. Remove requirement for sources to have a holding institution if source is a reconstruction #1631 requests that holding_institution-less sources be possible only for reconstruction sources. This will be added oncesource_completenessfield is available to mark reconstructions as such (see To-do's below).[No Shelfmark]toSource.shelfmarkfield.source_completenesschoice field to replace thefull_sourceboolean field and add the "Reconstruction" option. A command,populate_source_completeness, will populate the initial values of this field. Note that after this new field is populated, thefull_sourcefield will be redundant and can be removed (see To-do's below).production_methodchoice field to note (currently) whether a source is a manuscript or printed source.These changes are reflected in source create, edit, detail, and list pages. Relevant tests are also updated.
Makes cosmetic changes to the
Institutionmodel by changing various field defaults from latin abbreviations to english words.Adds the source's
namefield to source create, edit, and detail views and to the source heading.Performs some minor cosmetic changes: refactors
forms.pya bit with a newStyledChoiceFieldclass so that repeated changes to widget style attributes are no longer necessary and changes the ordering of the options in the "Holding Institution" input field on the Source admin page.To-Do's
populate_source_completenesscommand on serversCloses #1628.
Most display changes occur on the source list and source detail pages. In screenshots below, disregard repetitions of "(fragment)" on new version...these will be fixed in underlying data.