-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust source fields: holding_institution, name, production_method, source_completeness #1645
Merged
Commits on Oct 4, 2024
-
feat(source model): add source_completeness and production_method fields
Updates source create, source edit, and source detail pages. Adds command to populate the `source_completeness` field based on the current contents of the `full_source` field (which can be deleted after this field is populated).
Configuration menu - View commit details
-
Copy full SHA for ff92465 - Browse repository at this point
Copy the full SHA ff92465View commit details -
refactor(forms): create StyledChoiceField on forms
Removes the need to duplicate process of using default SelectWidget on ChoiceFields and then manually changing attributes.
Configuration menu - View commit details
-
Copy full SHA for 2a272c8 - Browse repository at this point
Copy the full SHA 2a272c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f646e77 - Browse repository at this point
Copy the full SHA f646e77View commit details -
fix(source): make holding_institution optional for sources
This commit removes the requirement for a source to have a holding_institution. Tests and forms are updated to account for this. The `migrate_records` command is updated so that sources with un-parseable sigla that are not otherwise accounted for (by virtue of being private collections or prints) do not have institution records made. Note: For the purposes of data migration, no constraint is added to sources to designate when no holding institution is necessary. After migration, these should be modified. Refs: DDMAL#1631
Configuration menu - View commit details
-
Copy full SHA for d97563c - Browse repository at this point
Copy the full SHA d97563cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 065ef07 - Browse repository at this point
Copy the full SHA 065ef07View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15fcf5b - Browse repository at this point
Copy the full SHA 15fcf5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20eba46 - Browse repository at this point
Copy the full SHA 20eba46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eb3df8 - Browse repository at this point
Copy the full SHA 8eb3df8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.