Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust source fields: holding_institution, name, production_method, source_completeness #1645

Merged
merged 8 commits into from
Oct 11, 2024
Merged

Adjust source fields: holding_institution, name, production_method, source_completeness #1645

merged 8 commits into from
Oct 11, 2024

Commits on Oct 4, 2024

  1. feat(source model): add source_completeness and production_method fields 

    Updates source create, source edit, and source detail pages.

Adds command to populate the `source_completeness` field based on the current contents of the `full_source` field (which can be deleted after this field is populated).
    @dchiller
    dchiller committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ff92465 View commit details
    Browse the repository at this point in the history

  2. refactor(forms): create StyledChoiceField on forms 

    Removes the need to duplicate process of using default SelectWidget on ChoiceFields and then manually changing attributes.
    @dchiller
    dchiller committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2a272c8 View commit details
    Browse the repository at this point in the history

  3. feat(source name): add source name to create, edit, and detail pages

    @dchiller
    dchiller committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f646e77 View commit details
    Browse the repository at this point in the history

  4. fix(source): make holding_institution optional for sources 

    This commit removes the requirement for a source to have a holding_institution.

Tests and forms are updated to account for this.

The `migrate_records` command is updated so that sources with un-parseable sigla that are not otherwise accounted for (by virtue of being private collections or prints) do not have institution records made.

Note: For the purposes of data migration, no constraint is added to sources to designate when no holding institution is necessary. After migration, these should be modified.

Refs: DDMAL#1631
    @dchiller
    dchiller committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d97563c View commit details
    Browse the repository at this point in the history

  5. chore: add migrations for previous commits 

    Refs: 14e0f56, 960fcf0,
a833370
    @dchiller
    dchiller committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    065ef07 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. fix(source admin form): order institutions by city then name

    @dchiller
    dchiller committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    15fcf5b View commit details
    Browse the repository at this point in the history

  2. fix(source display): format colloquial name and "(fragment)"

    @dchiller
    dchiller committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    20eba46 View commit details
    Browse the repository at this point in the history

  3. fix(source header): use Cantus prefix if no institution siglum

    @dchiller
    dchiller committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8eb3df8 View commit details
    Browse the repository at this point in the history