Handle errors with improper chant text field characters/syllabification fails #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes type annotations. Fixes deprecated call to assertFormError (see https://docs.djangoproject.com/en/4.2/topics/testing/tools/#django.test.SimpleTestCase.assertFormError). Mocks requests.get for entire class.
Reduces duplicate queries in the source create view. Removes a function that contained a duplicate test for the existence of a source.
Modifies chant create, edit, and detail views to prevent and catch text syllabification errors. Modifies edit syllabification view for the same. Invalidates chant text fields if they error on syllabification. Catches errors for texts with error rather than propagating to a server error.
lucasmarchd01
approved these changes
Oct 11, 2024
| required=True, | ||
| ) | ||
|
|
||
| manuscript_full_text = CantusDBLatinField( |
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom validators to all forms involving chant texts (chant create, chant edit, and syllabification edit) so that invalid texts cannot be saved.
Nests most attempted syllabifications and text-melody alignments in
tryblocks so that existing syllabification errors won't cause pages to fail to load.Does some refactoring on a variety of
test_views.test_chant.pytests to simplify, remove duplicate tests, and catch linting errors. In particular, two tests (test_view_url_reverse_nameandtest_template_used) repeated the logic of other tests for the same view (test_url_and_templatesandtest_view_url_path).Closes #1423. Closes #1626.