Exclude files from cop

NATIONALITIES is an array not a hash
DFE-Digital · Jan 23, 2025 · 5d35ac9 · 5d35ac9
1 parent e0d743e
commit 5d35ac9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -13,3 +13,7 @@ Rails/HelperInstanceVariable:
   Exclude:
     - 'app/helpers/content_helper.rb'
     - 'app/helpers/view_helper.rb'
+Style/HashSlice:
+  Exclude:
+    - 'app/queries/get_unsubmitted_applications_ready_to_nudge.rb' # NATIONALITIES is an array not a hash
+    - 'app/queries/get_incomplete_reference_applications_ready_to_nudge.rb' # NATIONALITIES is an array not a hash
diff --git a/app/queries/get_incomplete_reference_applications_ready_to_nudge.rb b/app/queries/get_incomplete_reference_applications_ready_to_nudge.rb
@@ -10,7 +10,9 @@ class GetIncompleteReferenceApplicationsReadyToNudge
   end
 
   def call
-    uk_and_irish_names = NATIONALITIES.slice(*ApplicationForm::BRITISH_OR_IRISH_NATIONALITIES).map(&:second)
+    uk_and_irish_names = NATIONALITIES.select do |code, _name|
+      code.in?(ApplicationForm::BRITISH_OR_IRISH_NATIONALITIES)
+    end.map(&:second)
 
     ApplicationForm
       # Only candidates with application_choices

diff --git a/app/queries/get_unsubmitted_applications_ready_to_nudge.rb b/app/queries/get_unsubmitted_applications_ready_to_nudge.rb
@@ -9,7 +9,9 @@ class GetUnsubmittedApplicationsReadyToNudge
     .map { |field| "#{field}_completed" }.freeze
 
   def call
-    uk_and_irish_names = NATIONALITIES.slice(*ApplicationForm::BRITISH_OR_IRISH_NATIONALITIES).map(&:second)
+    uk_and_irish_names = NATIONALITIES.select do |code, _name|
+      code.in?(ApplicationForm::BRITISH_OR_IRISH_NATIONALITIES)
+    end.map(&:second)
 
     ApplicationForm
       # Only candidates with unsubmitted application_choices