Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DR workflow fixes #10028

Merged
merged 2 commits into from
Nov 6, 2024
Merged

DR workflow fixes #10028

merged 2 commits into from
Nov 6, 2024

Conversation

RMcVelia
Copy link
Contributor

@RMcVelia RMcVelia commented Nov 5, 2024

Context

A couple of fixes for the DR workflows that were just added

Changes proposed in this pull request

Due to some non-standard settings in apply

  • change AZURE_RESOURCE_PREFIX to RESOURCE_NAME_PREFIX
  • change DB server name suffix from -pg to -psql

Guidance to review

PTR restore: https://github.com/DFE-Digital/apply-for-teacher-training/actions/runs/11686160618
PTR backup: https://github.com/DFE-Digital/apply-for-teacher-training/actions/runs/11686644424

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@RMcVelia
Copy link
Contributor Author

RMcVelia commented Nov 5, 2024

add DR workflows to aftt

Copy link
Contributor

@vipin-dfe vipin-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link
Contributor

@vipin-dfe vipin-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@RMcVelia RMcVelia merged commit bfce13b into main Nov 6, 2024
48 checks passed
@RMcVelia RMcVelia deleted the dr-workflow-fixes branch November 6, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants