Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[588] part 2, delete One Login pre release banners flag from features #10281

Draft
wants to merge 1 commit into
base: 588-tech-debt-revert-one-login-pre-release-comms-post-release
Choose a base branch
from

Conversation

elceebee
Copy link
Contributor

Context

This PR removes an unused Feature flag from the code base. See earlier PR for full context.

Changes proposed in this pull request

No UI changes, just removing a feature from the database.

Guidance to review

Link to Trello card

https://trello.com/c/m4unLeJX

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee elceebee self-assigned this Jan 20, 2025
@elceebee elceebee changed the title Delete One Login pre release banners flag from features [588] part 2, delete One Login pre release banners flag from features Jan 20, 2025
@elceebee elceebee force-pushed the 588-tech-debt-revert-one-login-pre-release-comms-post-release branch from 072f149 to 84e6633 Compare January 21, 2025 15:59
@elceebee elceebee force-pushed the 588-delete-pre-release-banner-feature-flag-from-db branch from 3a901fc to 47c246f Compare January 21, 2025 16:02
@elceebee elceebee force-pushed the 588-tech-debt-revert-one-login-pre-release-comms-post-release branch from 84e6633 to a1bf2ab Compare January 21, 2025 16:22
@elceebee elceebee force-pushed the 588-delete-pre-release-banner-feature-flag-from-db branch from 47c246f to 0e0118b Compare January 21, 2025 16:23
@elceebee elceebee force-pushed the 588-tech-debt-revert-one-login-pre-release-comms-post-release branch from a1bf2ab to d246dd4 Compare January 22, 2025 14:44
@elceebee elceebee force-pushed the 588-delete-pre-release-banner-feature-flag-from-db branch from 0e0118b to 57ca37a Compare January 22, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant