OneLogin Fallback Flow

[dcyoung-dev]

Context

As part of the introduction of One Login, we have had to make changes to how the Magic Links (fallback) login flow works.
This change will allow Candidates to sign in using either their Candidate email address or their OneLogin email address.

Changes proposed in this pull request

• Sign in emails now require a specific email address for the emails to be sent to
• Candidate.for_email now checks for connected OneLoginAuth records matching the email address
• Additional fallback flow tests have been added

Guidance to review

Link to Trello card

https://trello.com/c/BWEajuXS

Things to check

• If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
• This code does not rely on migrations in the same Pull Request
• If this code includes a migration adding or changing columns, it also backfills existing records for consistency
• If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
• If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
• API release notes have been updated if necessary
• If it adds a significant user-facing change, is it documented in the CHANGELOG?
• Attach the PR to the Trello card

[elceebee]

Found this bug here when you land on the expired link page

email.me.new.link.broken.mov

[CatalinVoineag]

I've dev tested this on my local. I can login with 2 emails for the same candidate, the candidate email and the one login email linked to the candidate. I can also create a new account if the email is not in OneLoginAuth or Candidate tables.

This works as expected, well done! 💯

[CatalinVoineag]

Maybe use the actual text rather than the translation

[elceebee]

I've tested all the scenarios I can think of with signing in / out, creating one login accounts, using expired links, etc on the review app. Everything is working as expected as far as I can tell.

It would be nice to have the test files use text instead of translation references, but not a blocker.

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ ArgumentError: unknown keyword: :email_address (ArgumentError) Sidekiq/ActionMailer::MailDeliveryJob View Issue

_{Did you find this useful? React with a 👍 or 👎}