Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[575] Change login page title when One Login is active #10288

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Jan 21, 2025

Context

As an existing Apply user I might think 'I already have an account with Apply' so it is confusing (unless I read the smaller text on the page) why I'm being asked to create an account. Especially as the 'Apply for teacher training' service name is displayed.

Changes proposed in this pull request

  • Change the title of the page
  • Also moved the heading below the error summary (accessibility fix while I'm here)
With magic link With One Login
image image

Guidance to review

Link to Trello card

https://trello.com/c/02DkpuXs

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee elceebee marked this pull request as ready for review January 21, 2025 13:37
@elceebee elceebee requested a review from a team January 21, 2025 13:38
@elceebee elceebee force-pushed the 575-bug-one-login-improve-clarity-of-creation-wording-on-create-or-sign-in-page branch from 2b2dd3c to 9c31ba5 Compare January 21, 2025 13:46
@elceebee elceebee changed the title Change login page title when One Login is active [575] Change login page title when One Login is active Jan 21, 2025
@elceebee elceebee self-assigned this Jan 21, 2025
@elceebee elceebee merged commit e4af037 into main Jan 21, 2025
23 checks passed
@elceebee elceebee deleted the 575-bug-one-login-improve-clarity-of-creation-wording-on-create-or-sign-in-page branch January 21, 2025 14:24
@elceebee
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants