-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement post-release one login banner for sign in page #10290
Merged
elceebee
merged 1 commit into
main
from
561-one-login-update-sign-in-service-banners-content-upon-release
Jan 21, 2025
Merged
Implement post-release one login banner for sign in page #10290
elceebee
merged 1 commit into
main
from
561-one-login-update-sign-in-service-banners-content-upon-release
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinVoineag
approved these changes
Jan 21, 2025
avinhurry
reviewed
Jan 21, 2025
spec/components/candidate_interface/one_login_post_release_sign_in_banner_component_spec.rb
Outdated
Show resolved
Hide resolved
elceebee
force-pushed
the
561-one-login-update-sign-in-service-banners-content-upon-release
branch
from
January 21, 2025 15:42
86ce9e4
to
134824f
Compare
avinhurry
approved these changes
Jan 21, 2025
Co-Authored-By: avinhurry <[email protected]>
elceebee
force-pushed
the
561-one-login-update-sign-in-service-banners-content-upon-release
branch
from
January 21, 2025 15:56
134824f
to
0aba405
Compare
dcyoung-dev
approved these changes
Jan 21, 2025
elceebee
deleted the
561-one-login-update-sign-in-service-banners-content-upon-release
branch
January 21, 2025 16:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are currently displaying a service banner letting people know that one login is coming on the sign in page. Once it is live, we want to show a different banner.
Changes proposed in this pull request
Guidance to review
Can be viewed locally or on the review app at
/rails/view_components/candidate_interface/one_login_pre_release_banners/one_login_post_release_sign_in_banner_component
, or if the one login feature is turned on, at/candidate/account
Link to Trello card
https://trello.com/c/oXhetRk7
Things to check