Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement post-release one login banner for sign in page #10290

Conversation

elceebee
Copy link
Contributor

Context

We are currently displaying a service banner letting people know that one login is coming on the sign in page. Once it is live, we want to show a different banner.

Changes proposed in this pull request

Pre-release Post-release
image image

Guidance to review

Can be viewed locally or on the review app at /rails/view_components/candidate_interface/one_login_pre_release_banners/one_login_post_release_sign_in_banner_component, or if the one login feature is turned on, at /candidate/account

Link to Trello card

https://trello.com/c/oXhetRk7

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Jan 21, 2025
@elceebee elceebee self-assigned this Jan 21, 2025
@elceebee elceebee marked this pull request as ready for review January 21, 2025 14:52
@elceebee
Copy link
Contributor Author

@github-actions github-actions bot temporarily deployed to review_aks-10290 January 21, 2025 14:58 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10290 January 21, 2025 15:12 Destroyed
@elceebee elceebee requested a review from a team January 21, 2025 15:33
@elceebee elceebee force-pushed the 561-one-login-update-sign-in-service-banners-content-upon-release branch from 86ce9e4 to 134824f Compare January 21, 2025 15:42
@github-actions github-actions bot temporarily deployed to review_aks-10290 January 21, 2025 15:52 Destroyed
@elceebee elceebee force-pushed the 561-one-login-update-sign-in-service-banners-content-upon-release branch from 134824f to 0aba405 Compare January 21, 2025 15:56
@github-actions github-actions bot temporarily deployed to review_aks-10290 January 21, 2025 16:09 Destroyed
@elceebee elceebee merged commit 1d91511 into main Jan 21, 2025
23 checks passed
@elceebee elceebee deleted the 561-one-login-update-sign-in-service-banners-content-upon-release branch January 21, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants