Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Api tokens counters to support api token index page #10294

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Jan 22, 2025

Context

We want more information at a glace on the support API tokens page.

This PR will add a counter of all the API tokens for our provider and a counter of the tokens used in the last 3 mounths.

Changes proposed in this pull request

Support API token index page

Guidance to review

Screenshot from 2025-01-22 16-28-22

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@CatalinVoineag CatalinVoineag self-assigned this Jan 22, 2025
@CatalinVoineag CatalinVoineag added the deploy_v2 Deploy the review app to AKS label Jan 22, 2025
@CatalinVoineag
Copy link
Contributor Author

@CatalinVoineag CatalinVoineag marked this pull request as ready for review January 22, 2025 14:40
@CatalinVoineag CatalinVoineag force-pushed the cv/vendor-token-stats branch 2 times, most recently from 52c270b to bcf0416 Compare January 22, 2025 14:46
@github-actions github-actions bot temporarily deployed to review_aks-10294 January 22, 2025 14:57 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10294 January 22, 2025 15:13 Destroyed
@CatalinVoineag CatalinVoineag requested a review from a team January 22, 2025 15:22
Copy link
Contributor

@elceebee elceebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any specs for this page? It might be good to have something basic in place if there isn't anything already.

Copy link
Collaborator

@avinhurry avinhurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is just for internal use but it would be nice to have the boxes the same size

image

@github-actions github-actions bot temporarily deployed to review_aks-10294 January 22, 2025 16:32 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10294 January 22, 2025 16:45 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10294 January 22, 2025 16:55 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10294 January 23, 2025 10:05 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10294 January 23, 2025 11:29 Destroyed
@CatalinVoineag CatalinVoineag merged commit 88e1e15 into main Jan 23, 2025
24 of 26 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/vendor-token-stats branch January 23, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants