Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.70.0 to 1.71.0 #10296

Merged
merged 3 commits into from
Jan 23, 2025
+7 −3
Merged

Bump rubocop from 1.70.0 to 1.71.0 #10296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4738e47
Bump rubocop from 1.70.0 to 1.71.0
dependabot[bot] Jan 23, 2025
e0d743e
A new cop (Style/HashSlice) has been merge
avinhurry Jan 23, 2025
5d35ac9
Exclude files from cop
avinhurry Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@ Rails/HelperInstanceVariable:
Exclude:
- 'app/helpers/content_helper.rb'
- 'app/helpers/view_helper.rb'
Style/HashSlice:
Exclude:
- 'app/queries/get_unsubmitted_applications_ready_to_nudge.rb' # NATIONALITIES is an array not a hash
- 'app/queries/get_incomplete_reference_applications_ready_to_nudge.rb' # NATIONALITIES is an array not a hash
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ GEM
rspec-support (3.13.1)
rspec_junit_formatter (0.6.0)
rspec-core (>= 2, < 4, != 2.12.0)
rubocop (1.70.0)
rubocop (1.71.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
Expand Down
2 changes: 1 addition & 1 deletion app/forms/candidate_interface/other_qualification_details_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def title

PERSISTENT_ATTRIBUTES = %w[qualification_type other_uk_qualification_type non_uk_qualification_type subject predicted_grade grade award_year institution_country].freeze
def persistent_attributes(application_qualification)
application_qualification.attributes.select { |key, _| PERSISTENT_ATTRIBUTES.include?(key) }
application_qualification.attributes.slice(*PERSISTENT_ATTRIBUTES)
end

def grade_hint
Expand Down
2 changes: 1 addition & 1 deletion app/presenters/rejection_reasons/rejection_reasons_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def tailored_advice_reasons
hash.delete('safeguarding')
end

hash.filter { |key, _value| key.in? VALID_HIGH_LEVEL_ADVICE_REASON_CODES }
hash.slice(*VALID_HIGH_LEVEL_ADVICE_REASON_CODES)
end

def render_tailored_advice_section_headings?
Expand Down
Loading