Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to SessionError table #10298

Closed
wants to merge 1 commit into from

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Jan 23, 2025

Context

There are two types of errors the candidate can encounter when using one
login. Typical 500 errors and when a user uses the wrong email address

We need to know what error the candidate gets to redirect them to the
correct page.

Prior to this change we are redirecting the candidate to wrong_email
error page even if it's a 500 error page.

Adding a enum to the SessionError table makes it easier to
distinguish between these errors. Better than storing this information
in the session.

Problematic code, we can get here from the failure endpoint which should not redirect the user to wrong email page but to 500 page

There's a part 2 to this PR here #10299

Changes proposed in this pull request

Guidance to review

Problem that I'm trying to fix, this should go to 500

kazam_uq96hq22.movie.mp4

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@CatalinVoineag CatalinVoineag self-assigned this Jan 23, 2025
@CatalinVoineag CatalinVoineag force-pushed the cv/one-login-session-error-migration branch from 9ed8da3 to 1a5f96b Compare January 23, 2025 17:39
@CatalinVoineag CatalinVoineag marked this pull request as ready for review January 23, 2025 17:44
@CatalinVoineag CatalinVoineag requested a review from a team January 23, 2025 17:44
@CatalinVoineag CatalinVoineag force-pushed the cv/one-login-session-error-migration branch from 1a5f96b to 5845131 Compare January 23, 2025 17:54
There are two types of errors the candidate can encounter when using one
login. Typical 500 errors and when a user uses the wrong email address

We need to know what error the candidate gets to redirect them to the
correct page.

Prior to this change we are redirecting the candidate to wrong_email
error page even if it's a 500 error page.

Adding a error_type to the SessionError table makes it easier to
distinguish between these errors. Better than storing this information
in the session.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant