Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter and export support vendor api page #10302

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Jan 24, 2025

Context

We want to make the support vendor api page more usable.

This commit adds a vendor filter to the page and a Download CSV button which will take the filtered results and put them into a CSV and adding all the users of each provider.

Changes proposed in this pull request

Filters and download csv

Guidance to review

Go on review app and export a list of vendor API tokens

Screencast.2025-01-24.09.36.07.mp4

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@CatalinVoineag CatalinVoineag self-assigned this Jan 24, 2025
@CatalinVoineag CatalinVoineag marked this pull request as ready for review January 24, 2025 09:37
@CatalinVoineag
Copy link
Contributor Author

@CatalinVoineag CatalinVoineag requested a review from a team January 24, 2025 09:41
@CatalinVoineag CatalinVoineag added the deploy_v2 Deploy the review app to AKS label Jan 24, 2025
@github-actions github-actions bot temporarily deployed to review_aks-10302 January 24, 2025 09:51 Destroyed
Copy link
Contributor

@elceebee elceebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the review app -- there aren't any vendors, so couldn't test the filters, but I added some tokens and revoked others and the CSV download seemed to work correctly. Nice work fitting this in with all the OneLogin stuff happening at the same time!

We want to make the support vendor api page more usable.

This commit adds a vendor filter to the page and a Download CSV button
which will take the filtered results and put them into a CSV and adding
all the users of each provider.
@elceebee elceebee force-pushed the cv/vendor-tokens-filter branch from 6aaf9a6 to b121463 Compare January 27, 2025 10:11
@github-actions github-actions bot temporarily deployed to review_aks-10302 January 27, 2025 10:16 Destroyed
@elceebee elceebee merged commit cd49641 into main Jan 27, 2025
24 checks passed
@elceebee elceebee deleted the cv/vendor-tokens-filter branch January 27, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants