-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[593] Edit email subscription status (support functionality) #10323
Merged
avinhurry
merged 9 commits into
main
from
593-support-console-the-ability-to-see-and-edit-whether-a-candidate-is-unsubscribed-from-subscription-emails
Jan 30, 2025
Merged
[593] Edit email subscription status (support functionality) #10323
avinhurry
merged 9 commits into
main
from
593-support-console-the-ability-to-see-and-edit-whether-a-candidate-is-unsubscribed-from-subscription-emails
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinhurry
force-pushed
the
593-support-console-the-ability-to-see-and-edit-whether-a-candidate-is-unsubscribed-from-subscription-emails
branch
from
January 29, 2025 18:03
e86b673
to
adcecf6
Compare
avinhurry
force-pushed
the
593-support-console-the-ability-to-see-and-edit-whether-a-candidate-is-unsubscribed-from-subscription-emails
branch
from
January 29, 2025 18:20
adcecf6
to
ba1afd4
Compare
avinhurry
force-pushed
the
593-support-console-the-ability-to-see-and-edit-whether-a-candidate-is-unsubscribed-from-subscription-emails
branch
from
January 29, 2025 19:46
5b66f7c
to
db78834
Compare
dcyoung-dev
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, I've left a few comments/suggestions but none of them are blockers
app/controllers/support_interface/application_forms/email_subscription_controller.rb
Show resolved
Hide resolved
app/controllers/support_interface/application_forms/email_subscription_controller.rb
Outdated
Show resolved
Hide resolved
spec/system/support_interface/editing_email_subscription_status_spec.rb
Outdated
Show resolved
Hide resolved
avinhurry
deleted the
593-support-console-the-ability-to-see-and-edit-whether-a-candidate-is-unsubscribed-from-subscription-emails
branch
January 30, 2025 11:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We anticipate that going forward the Support team (and ourselves) will find it useful be able to see if a candidate is unsubscribed, and perhaps also edit this on their behalf should they change their mind, or request it direct via a support query rather than using an unsubscribe link.
Changes proposed in this pull request
Screenshot
Things to check