Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[593] Edit email subscription status (support functionality) #10323

Conversation

avinhurry
Copy link
Collaborator

@avinhurry avinhurry commented Jan 29, 2025

Context

We anticipate that going forward the Support team (and ourselves) will find it useful be able to see if a candidate is unsubscribed, and perhaps also edit this on their behalf should they change their mind, or request it direct via a support query rather than using an unsubscribe link.

Changes proposed in this pull request

  • Surface the candidate email subscription status on the support index page
  • Add the ability to update the status by clicking the change button

Screenshot

Screenshot 2025-01-29 at 21 11 43 image

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@avinhurry avinhurry force-pushed the 593-support-console-the-ability-to-see-and-edit-whether-a-candidate-is-unsubscribed-from-subscription-emails branch from e86b673 to adcecf6 Compare January 29, 2025 18:03
@avinhurry avinhurry force-pushed the 593-support-console-the-ability-to-see-and-edit-whether-a-candidate-is-unsubscribed-from-subscription-emails branch from adcecf6 to ba1afd4 Compare January 29, 2025 18:20
@avinhurry avinhurry force-pushed the 593-support-console-the-ability-to-see-and-edit-whether-a-candidate-is-unsubscribed-from-subscription-emails branch from 5b66f7c to db78834 Compare January 29, 2025 19:46
@avinhurry
Copy link
Collaborator Author

@avinhurry avinhurry added the deploy_v2 Deploy the review app to AKS label Jan 29, 2025
@github-actions github-actions bot temporarily deployed to review_aks-10323 January 29, 2025 20:03 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10323 January 30, 2025 10:06 Destroyed
@avinhurry avinhurry marked this pull request as ready for review January 30, 2025 10:12
@avinhurry avinhurry requested a review from a team January 30, 2025 10:21
Copy link
Collaborator

@dcyoung-dev dcyoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I've left a few comments/suggestions but none of them are blockers

@github-actions github-actions bot temporarily deployed to review_aks-10323 January 30, 2025 10:56 Destroyed
@avinhurry avinhurry merged commit d61d0ef into main Jan 30, 2025
24 checks passed
@avinhurry avinhurry deleted the 593-support-console-the-ability-to-see-and-edit-whether-a-candidate-is-unsubscribed-from-subscription-emails branch January 30, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants