Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks for the strategy parameter before acting #10326

Merged

Conversation

dcyoung-dev
Copy link
Collaborator

Context

While investigating Sentry Errors we identified that the auth/failure endpoint was capturing both OneLogin and DfE Sign in errors.

Changes proposed in this pull request

Update the controller to do nothing if the endpoint is not hit by the OneLogin strategy

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@dcyoung-dev dcyoung-dev requested a review from a team January 30, 2025 15:25
@dcyoung-dev dcyoung-dev self-assigned this Jan 30, 2025
@dcyoung-dev dcyoung-dev merged commit c154462 into main Jan 30, 2025
23 checks passed
@dcyoung-dev dcyoung-dev deleted the dy-auth-failure-endpoint-only-handles-onelogin-failures branch January 30, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants