Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage framework evaluations #1641

Merged
merged 22 commits into from
Nov 29, 2023
Merged

Manage framework evaluations #1641

merged 22 commits into from
Nov 29, 2023

Conversation

ryantk
Copy link
Contributor

@ryantk ryantk commented Oct 18, 2023

Changes in this PR

Screen-shots or screen-capture of UI changes

@viezly
Copy link

viezly bot commented Oct 18, 2023 •
edited
Loading

This pull request is split into 51 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • app
  • app/assets/stylesheets
  • app/components/activity_log
  • app/controllers
  • app/cores
  • app/forms/support
  • app/javascript
  • app/jobs
  • app/models
  • app/presenters/support
  • app/services/support
  • app/views
  • config
  • db
  • db/migrate
  • lib/microsoft_graph
  • lib/tasks
  • spec
  • spec/features
  • spec/fixtures
  • spec/forms/support/messages
  • spec/integration
  • spec/presenters/support/messages
  • spec/services/support

@ryantk ryantk force-pushed the framework-evaluation-email-sync branch 6 times, most recently from 58ad931 to d818b67 Compare October 19, 2023 14:34
@ryantk ryantk force-pushed the framework-evaluation-email-sync branch 2 times, most recently from e967742 to 8a4af95 Compare November 3, 2023 10:09
@ryantk ryantk force-pushed the framework-evaluation-email-sync branch from 8a4af95 to 51cea6b Compare November 3, 2023 11:26
@ryantk ryantk changed the title WIP Framework evaluation email sync Manage framework evaluations Nov 3, 2023
@ryantk ryantk force-pushed the framework-evaluation-email-sync branch from 51cea6b to bb92184 Compare November 3, 2023 11:34
@ryantk ryantk force-pushed the framework-evaluation-email-sync branch from bb92184 to 971741a Compare November 3, 2023 12:53
@ryantk ryantk force-pushed the framework-evaluation-email-sync branch 2 times, most recently from 8f515f1 to 6436321 Compare November 8, 2023 10:28
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 8, 2023
View reviewed changes
app/controllers/concerns/has_ticket.rb Dismissed Show resolved Hide resolved
@ryantk ryantk force-pushed the framework-evaluation-email-sync branch 4 times, most recently from 10d6280 to 0411ec9 Compare November 16, 2023 15:53
@ryantk ryantk force-pushed the framework-evaluation-email-sync branch 4 times, most recently from 94d73c4 to c4ff053 Compare November 22, 2023 12:08
@ryantk ryantk force-pushed the framework-evaluation-email-sync branch 4 times, most recently from f3f612f to b65a418 Compare November 24, 2023 14:30
ryantk and others added 22 commits November 29, 2023 10:43
@ryantk
refactor: emails can be polymorphicly attached
711662b
@ryantk
refactor: big refactor of email sync
de760d5
@ryantk
feat(fworks): evaluations can sync emails
d397dbc
@ryantk
feat(fworks): nicer activity log
c718619
@ryantk
feat(fworks): reply to emails
d4f99c1
@ryantk
feat(fworks): list and edit email attachments
5bdbaab
@ryantk
feat(fworks): create new thread
9301cc4
@ryantk
feat(fworks): further activity log improvements
54bf6b6
@EdwinKruglov @ryantk
feat(fworks): quick edit framework evaluations
f468251
@EdwinKruglov @ryantk
feat(cms-fworks): transfer cases to evaluations
38d53a9 
Jira: PWNN-1646
@EdwinKruglov @ryantk
feat(cms): allow to move emails from cases to evaluations
fb7bbd5 
Jira: PWNN-1647
@ryantk
refactor: FE activity log items now view components
7195a7e
@ryantk
feat(fworks): evaluation workflows
cdc403c
@ryantk
feat(fworks): further evaluation workflows
902f83a
@ryantk
feat(fworks): additional filters for evals
60c1efb
@ryantk
feat(cms): select frameworks from register
1f49452
@ryantk
refactor: feature flag for register fw select
50b7f22
@ryantk
feat(cms): can edit agents email when nil
edba1a6
@ryantk
feat(fworks): prevent errors in spreadsheet upload
d8f2c7f
@ryantk
fix(fworks): show dfe review date not end date
6ee9a5b
@ryantk
feat(fworks): faf start and end dates
708e006
@ryantk
feat(fworks): component for eval cancelled event
ee1a542
@ryantk ryantk force-pushed the framework-evaluation-email-sync branch from 13d5310 to ee1a542 Compare November 29, 2023 10:44
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 28 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ryantk ryantk merged commit fa424d9 into main Nov 29, 2023
18 of 19 checks passed
@ryantk ryantk deleted the framework-evaluation-email-sync branch November 29, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenaabbott11 serenaabbott11 Awaiting requested review from serenaabbott11 serenaabbott11 is a code owner

@EdwinKruglov EdwinKruglov Awaiting requested review from EdwinKruglov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryantk @EdwinKruglov