Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1694 - feat(fworks): quick edit framework evaluations #1649

Merged
merged 1 commit into from
Nov 2, 2023
Merged

1694 - feat(fworks): quick edit framework evaluations #1649

merged 1 commit into from
Nov 2, 2023

Conversation

EdwinKruglov
Copy link
Contributor

Changes in this PR

  • added next_key_date and next_key_date_description fields to frameworks_evaluations
  • added the ability to "Quick edit" framework evaluations where the user can add notes and change the next key date

Jira: PWNN-1694

@EdwinKruglov EdwinKruglov self-assigned this Oct 31, 2023
@viezly viezly
Copy link

viezly bot commented Oct 31, 2023

This pull request is split into 6 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • app/controllers
  • app/models
  • app/views/frameworks
  • config
  • db
  • spec/features/frameworks/evaluations
  • spec/models/support/case/validation

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryantk ryantk merged commit 085a7f9 into framework-evaluation-email-sync Nov 2, 2023
12 of 16 checks passed
@ryantk ryantk deleted the 1694-framework-eval-quick-edit branch November 2, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantk ryantk ryantk approved these changes

@serenaabbott11 serenaabbott11 Awaiting requested review from serenaabbott11

Assignees

@EdwinKruglov EdwinKruglov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwinKruglov @ryantk