Store current school on the journey session #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://s118d02-app-pr-2793-as.azurewebsites.net/additional-payments/claim |
felixclack
force-pushed
the
current-school-journey
branch
7 times, most recently
from
9c8304b to
e3b8ca5
Compare
The base Form class handles assigning params to defined attributes and so this line in the initialize method is redundant.
We're moving all the answers to the journey session, so this change ensures we save the current_school_id here too.
felixclack
force-pushed
the
current-school-journey
branch
2 times, most recently
from
14ecd5e to
f8cd8d7
Compare
The journey session holds a reference to the current school and this can be used when calculating the slug and page sequence.
felixclack
force-pushed
the
current-school-journey
branch
from
f8cd8d7 to
62c2510
Compare
kenfodder
reviewed
Jun 6, 2024
| @@ -236,9 +236,10 @@ def induction_question_required? | |||
| end | |||
|
|
|||
| def ecp_school_selected? | |||
| return false unless claim.eligibility.current_school | |||
| school = answers&.current_school || claim.eligibility.current_school | |||
There was a problem hiding this comment.
Wondering if we can use the shim to do this, it would handle the ORing of this? /cc @rjlynch - would that make sense?
slorek
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add the current_school selection to the journey session answers.
The code that calculates the slug sequence can reference this new location safely.
When it comes to the eligibility checks, the coupling to the claim requires changes
that expand the scope beyond what is reasonable for this work.
For now, we will still store the current school on the claim object as well as the session.
This ensures that the eligibility checks continue to work. A follow on PR will handle
removing this update when the eligibility check has been decoupled from the claim.