Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPT-2104 Redirect to start page if no reminder in session #3500

Merged
merged 1 commit into from
Jan 21, 2025
Merged

CAPT-2104 Redirect to start page if no reminder in session #3500

merged 1 commit into from
Jan 21, 2025

Conversation

kenfodder
Copy link
Contributor

No description provided.

@kenfodder kenfodder added the deploy Deploy a review app for this PR label Jan 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3500-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3500-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3500-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3500-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3500-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3500-web.test.teacherservices.cloud/admin

@kenfodder kenfodder force-pushed the CAPT-2104-reminder-confirmation-error branch from bcb6f0c to 5fb221a Compare January 8, 2025 23:18
@kenfodder kenfodder requested review from slorek, asmega and rjlynch January 9, 2025 09:44
@kenfodder kenfodder marked this pull request as ready for review January 9, 2025 09:44
@kenfodder kenfodder force-pushed the CAPT-2104-reminder-confirmation-error branch from 5fb221a to d89bae3 Compare January 9, 2025 19:12
rjlynch
rjlynch approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - may want to show the user a flash message or something

@kenfodder kenfodder force-pushed the CAPT-2104-reminder-confirmation-error branch from d89bae3 to 02df821 Compare January 21, 2025 09:12
@kenfodder kenfodder merged commit c2ad640 into master Jan 21, 2025
15 checks passed
@kenfodder kenfodder deleted the CAPT-2104-reminder-confirmation-error branch January 21, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

@slorek slorek Awaiting requested review from slorek

@asmega asmega Awaiting requested review from asmega

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenfodder @rjlynch