CAPT 2083/slc upload audit #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
CAPT-2083/slc-upload-audit
branch
6 times, most recently
from
4cc448b to
5385820
Compare
rjlynch
force-pushed
the
CAPT-2083/slc-upload-audit
branch
from
5385820 to
2638e42
Compare
rjlynch
force-pushed
the
CAPT-2083/slc-upload-audit
branch
from
2638e42 to
44b0238
Compare
rjlynch
force-pushed
the
CAPT-2083/slc-upload-audit
branch
from
44b0238 to
651af99
Compare
asmega
approved these changes
Jan 16, 2025
Claims can no longer be "unsubmitted" so we don't need to test those scenarios in this spec.
When the SLC data upload runs we want to use the existing amendments mechanism to record any changes to the claim. As amending a claim requires a user to be associated with the amendment we need to pass who triggered the SLC upload down to the `ClaimStudentLoanDetailsUpdater`. We've had to slightly change the validation on `StudentLoans::Eligibility` to check if the repayment amount has changed as there's one test (`spec/features/admin/upload_slc_data_spec.rb`) where: * No SLC data is found for a claim * The claim has a student_loan_repayment_amount of `0` * The claim's plan is expected to change from `not_applicable` to `nil` * The claim's `has_student_loan` is expected to change from `false` to `nil` Without changing the validation on the eligibility we can't pass this test as amending the claim errors due to the `0` student loan repayment amount.
rjlynch
force-pushed
the
CAPT-2083/slc-upload-audit
branch
from
651af99 to
7d5e0ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create audit trail when SLC upload runs
When the SLC data upload runs we want to use the existing amendments
mechanism to record any changes to the claim. As amending a claim
requires a user to be associated with the amendment we need to pass who
triggered the SLC upload down to the
ClaimStudentLoanDetailsUpdater.We've had to slightly change the validation on
StudentLoans::Eligibilityto check if the repayment amount has changedas there's one test (
spec/features/admin/upload_slc_data_spec.rb)where:
0not_applicabletonilhas_student_loanis expected to change fromfalsetonilWithout changing the validation on the eligibility we can't pass this
test as amending the claim errors due to the
0student loan repaymentamount.