CAPT 1797/qualification report tweak #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Want to use an or condition on task and it's neater to call a scope rather than where with the string name!
This context allows skipping validations and is used in the claim verifiers models, if we want to set up tasks in our specs to match those created in claim verifiers we need to be able to use this context.
Even if the task has passed we want to include claims that failed the DQT api checks. We can identify these claimms as they have a task with a `claim_verifier_match` of `:none`.
Claims don't persist `dqt_teacher_status`
On prod db: `Claim.where.not(dqt_teacher_status: {}).count #=> 3` and we
don't want to hit the dqt api for each claim when generating the report,
so we need to parse the notes file to get the DQT data into the report.
kenfodder
approved these changes
Jan 29, 2025
| @@ -30,5 +30,9 @@ | |||
| trait :automated do | |||
| manual { false } | |||
| end | |||
|
|
|||
| trait :claim_verifier_context do | |||
| to_create { it.save!(context: :claim_verifier) } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tweaks to the DQT qualifications report:
Might be easier to review each commit separately.