Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPT-2041] More FE provider verification chasers #3538

Merged
merged 9 commits into from
Jan 30, 2025
Merged

[CAPT-2041] More FE provider verification chasers #3538

merged 9 commits into from
Jan 30, 2025

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Jan 29, 2025 •
edited
Loading

Context

  • https://dfedigital.atlassian.net/browse/CAPT-2041
  • Now geared to be able to send infinite number of FE provider verification chasers
  • Configurable with CHASE_INTERVALS
  • provider_verification_chase_email_last_sent_at is no longer used and can be removed after this change is merged
  • Instead provider_verification_email_last_sent_at simply stores last time we email the provider
  • New column provider_verification_email_count now used to indicate how many times we have contacted provider

@asmega asmega marked this pull request as ready for review January 29, 2025 15:58
rjlynch
rjlynch approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

db/migrate/20250129115013_add_provider_verification_email_count.rb Show resolved Hide resolved
kenfodder
kenfodder approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@kenfodder kenfodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, comment left on the migration, might cause an issue.

db/migrate/20250129115013_add_provider_verification_email_count.rb Show resolved Hide resolved
@asmega asmega force-pushed the fe-provider-more-reminder branch from e80b30e to 8428b27 Compare January 30, 2025 11:08
@asmega asmega merged commit 8c9ba20 into master Jan 30, 2025
15 checks passed
@asmega asmega deleted the fe-provider-more-reminder branch January 30, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenfodder kenfodder kenfodder approved these changes

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asmega @kenfodder @rjlynch