[CPDLP-3933] Add Mentor call off contract to ECF #5442
Conversation
|
Review app deployed to https://cpd-ecf-review-5442-web.test.teacherservices.cloud |
| t.belongs_to :lead_provider, null: false, foreign_key: true, type: :uuid, index: true | ||
| t.belongs_to :cohort, null: false, foreign_key: true, type: :uuid, index: true | ||
|
|
||
| t.string :version, null: false, default: "0.0.1" |
There was a problem hiding this comment.
Are we just sticking to the call off contract versioning/logic?
There was a problem hiding this comment.
Think so.. but also we need to sync up this value with contract_version from statements.
There was a problem hiding this comment.
As discussed on call yesterday we'll keep the current version implementation
| @@ -25,6 +25,7 @@ class LeadProvider < ApplicationRecord | |||
| has_many :partnership_csv_uploads | |||
| has_many :lead_provider_api_tokens | |||
| has_one :call_off_contract | |||
| has_many :mentor_call_off_contracts | |||
There was a problem hiding this comment.
Worth updating the LP spec here?
| @@ -25,6 +25,7 @@ class LeadProvider < ApplicationRecord | |||
| has_many :partnership_csv_uploads | |||
| has_many :lead_provider_api_tokens | |||
| has_one :call_off_contract | |||
There was a problem hiding this comment.
as discussed this seems wrong and it is, when we call this it just picks one contract for lead provider, checking the code it is called BUT not used anywhere except in banding tracker which is deprecated and not built correctly/used. We can add a tech debt ticket to remove this
mooktakim
force-pushed
the
3933-add-mentor-call-off-contract-to-ecf-2
branch
from
fc30611 to
c53ab10
Compare
spec/services/importers/create_mentor_call_off_contract_spec.rb
Outdated
Show resolved
Hide resolved
mooktakim
force-pushed
the
3933-add-mentor-call-off-contract-to-ecf-2
branch
from
c53ab10 to
11dc2bf
Compare
Context
Changes proposed in this pull request
MentorCallOffContractmodelImporters::CreateMentorCallOffContractserviceGuidance to review