[CPDLP-3968] Amend void declarations service to include ineligible statement line items #5487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandroalemao
force-pushed
the
CPDLP-3968
branch
from
be80085 to
ff44d31
Compare
|
Review app deployed to https://cpd-ecf-review-5487-web.test.teacherservices.cloud |
leandroalemao
force-pushed
the
CPDLP-3968
branch
from
ff44d31 to
fac7347
Compare
cwrw
reviewed
Jan 28, 2025
| @@ -62,9 +62,12 @@ | |||
| ) | |||
| end | |||
|
|
|||
| it "can be voided" do | |||
| let(:line_item) { participant_declaration.statement_line_items.first } | |||
There was a problem hiding this comment.
Maybe we group the specs correctly, as the below context for when declaration is attached to a statement will include the line items instead, where we can check all types there perhaps?
leandroalemao
force-pushed
the
CPDLP-3968
branch
from
fac7347 to
6d2f226
Compare
cwrw
reviewed
Jan 28, 2025
| @@ -91,37 +75,60 @@ | |||
| end | |||
| end | |||
|
|
|||
| context "when declaration is submitted" do | |||
There was a problem hiding this comment.
can we keep submitted/this test please? as it can be voided but won't be in a statement
leandroalemao
force-pushed
the
CPDLP-3968
branch
from
6d2f226 to
faecc74
Compare
cwrw
approved these changes
Jan 28, 2025
mooktakim
approved these changes
Jan 29, 2025
…atement line items
leandroalemao
force-pushed
the
CPDLP-3968
branch
from
faecc74 to
304cdb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Contract managers are not able to see voids for ineligible declarations in the CSV extracts.
Changes proposed in this pull request
ineligiblestatement line items, so the record state is updated tovoided;submittedline items from the logic as it's not a valid state forStatementLineItem. Checked prod and there's nosubmittedline itens currently in the db;