Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore npq_course_id on ParticipantProfile #5499

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Conversation

ethax-ross
Copy link
Collaborator

@ethax-ross ethax-ross commented Jan 30, 2025

Jira-4011

Context

This is no longer used; we are ignoring it ahead of dropping the column in a follow up PR.

Changes proposed in this pull request

  • Ignore npq_course_id on ParticipantProfile
  • Remove npq_course_id from dfe-analytics

Guidance for review

Follow on PR: #5500.

This is no longer used; we are ignoring it ahead of dropping the column in a follow up PR.
As we are dropping this column from the database.
Copy link

Review app deployed to https://cpd-ecf-review-5499-web.test.teacherservices.cloud

@ethax-ross ethax-ross marked this pull request as ready for review January 30, 2025 11:13
@ethax-ross ethax-ross requested a review from a team January 30, 2025 11:13
@ethax-ross ethax-ross added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 44a8744 Jan 31, 2025
39 checks passed
@ethax-ross ethax-ross deleted the 4011-ignore-course-id branch January 31, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants