[CPDLP-3958] Remove extra lead providers from seeds #5521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-ecf-review-5521-web.test.teacherservices.cloud |
cwrw
reviewed
Feb 10, 2025
app/models/lead_provider.rb
Outdated
| @@ -2,6 +2,16 @@ | |||
|
|
|||
| # This is actually ECFLeadProvider in all but name. See https://github.com/DFE-Digital/early-careers-framework/issues/698 | |||
| class LeadProvider < ApplicationRecord | |||
| ALL_PROVIDERS = [ | |||
There was a problem hiding this comment.
I wonder if this list can be in the seeds not in the main model? as we already define them there and this avoids confusion?
ethax-ross
reviewed
Feb 10, 2025
leandroalemao
force-pushed
the
CPDLP-3958
branch
from
8947111 to
2615c50
Compare
cwrw
approved these changes
Feb 11, 2025
leandroalemao
force-pushed
the
CPDLP-3958
branch
from
2615c50 to
76d35d7
Compare
leandroalemao
temporarily deployed
to
staging
GitHub Actions
Inactive
mooktakim
reviewed
Feb 11, 2025
Comment on lines
16
to
17
| let(:lead_provider_1) { create(:lead_provider, name: "Capita") } | ||
| let(:school_1) { NewSeeds::Scenarios::Schools::School.new.build.with_partnership_in(cohort:, lead_provider: lead_provider_1).chosen_fip_and_partnered_in(cohort:) } |
There was a problem hiding this comment.
school_1 doesn't seem to be used, not needed maybe?
There was a problem hiding this comment.
Great spot tks 👍 😄
mooktakim
approved these changes
Feb 11, 2025
leandroalemao
force-pushed
the
CPDLP-3958
branch
2 times, most recently
from
01e6e58 to
8c5da41
Compare
ethax-ross
approved these changes
Feb 11, 2025
leandroalemao
force-pushed
the
CPDLP-3958
branch
from
8c5da41 to
e59047b
Compare
leandroalemao
temporarily deployed
to
staging
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We currently have a set of known providers in production, however in seeds we create many other providers unnecessarily and the data for contracts and statements is not set up properly.
Changes proposed in this pull request
Ensure all seed data and participants for both ECTs/Mentors is attached to only the known lead providers.