Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Save all chart images' button to School and Trust cost comparison pages #1798

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

WolfyUK
Copy link
Collaborator

@WolfyUK WolfyUK commented Jan 23, 2025

Context

AB#246636 AB#242099

Change proposed in this pull request

  • Added <ShareContentByElements /> component for use with any HTMLElement that generates .pngs for each matching element and bundles them into a .zip which is then sent to the client
  • Added default implementation to be to select by matching element class name(s), which may be outside the React context
  • Added optional progress indicator to <ShareContentByElements /> component
  • Added 'save all' button to School and Trust comparison pages
  • Ensured if 'table' mode selected in chart radios then first select 'chart' before saving chart images

Guidance to review

Multiple image save feature may be demoed in the vite dev server. To view in the web app, build front-end-components and copy to Web before visiting the affected pages. Seems to be performant even on the largest Trust, but it is anticipated that a future design crit may raise additional work, especially:

  • around the 'progress' indicator that provides additional context to the user during the potentially long-running task
  • visibility/disabled state/location of the button

Checklist (add/remove as appropriate)

  • Work items have been linked (use AB#)
  • Your code builds clean without any errors or warnings
  • You have run all unit/integration tests and they pass
  • Your branch has been rebased onto main
  • You have tested by running locally
  • You have reviewed with UX/Design

…TMLElement

Added default implementation to be to select by matching element class name(s), which may be outside the React context
@WolfyUK WolfyUK marked this pull request as draft January 23, 2025 13:51
@WolfyUK WolfyUK force-pushed the feature/246636/save-all-button branch from fe301f2 to ab2685d Compare January 23, 2025 13:53
@WolfyUK WolfyUK marked this pull request as ready for review January 23, 2025 14:00
@WolfyUK WolfyUK merged commit d9f195d into main Jan 23, 2025
15 checks passed
@WolfyUK WolfyUK deleted the feature/246636/save-all-button branch January 23, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants