Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SNYK scan to build image #1163

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Add SNYK scan to build image #1163

merged 1 commit into from
Jan 17, 2025

Conversation

RMcVelia
Copy link
Contributor

@RMcVelia RMcVelia commented Jan 13, 2025 •
edited
Loading

Context

We should scan the build image using SNYK

Changes proposed in this pull request

  • Update the build workflow to use our build-docker-image github action, and add SNYK key so it runs the scan.
  • Add weekly build without caching workflow

Guidance to review

Check

Link to Trello card

https://trello.com/c/9tIfEgW1/2166-scan-docker-image-in-all-repositories

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@RMcVelia RMcVelia requested a review from a team as a code owner January 13, 2025 14:57
@RMcVelia RMcVelia force-pushed the 2166-scan-docker-image-in-all-repositories branch from e69510f to 0f7e148 Compare January 13, 2025 15:21
@github-actions GitHub Actions
Copy link

AKS review app deployed to https://find-a-lost-trn-review-pr-1163.test.teacherservices.cloud

@RMcVelia RMcVelia force-pushed the 2166-scan-docker-image-in-all-repositories branch from 31652a9 to 0f7e148 Compare January 13, 2025 15:46
@RMcVelia RMcVelia force-pushed the 2166-scan-docker-image-in-all-repositories branch from 0f7e148 to b0411f0 Compare January 13, 2025 15:48
@RMcVelia RMcVelia force-pushed the 2166-scan-docker-image-in-all-repositories branch from b0411f0 to bd1e403 Compare January 14, 2025 11:32
@RMcVelia RMcVelia force-pushed the 2166-scan-docker-image-in-all-repositories branch from bd1e403 to 610671d Compare January 14, 2025 12:02
@RMcVelia RMcVelia force-pushed the 2166-scan-docker-image-in-all-repositories branch from 610671d to 6d47429 Compare January 14, 2025 12:16
@RMcVelia RMcVelia force-pushed the 2166-scan-docker-image-in-all-repositories branch from 6d47429 to 9bdf89d Compare January 14, 2025 12:23
@RMcVelia RMcVelia force-pushed the 2166-scan-docker-image-in-all-repositories branch from 9bdf89d to 2570ca9 Compare January 16, 2025 13:30
@RMcVelia RMcVelia force-pushed the 2166-scan-docker-image-in-all-repositories branch from 2570ca9 to 1f7df8e Compare January 16, 2025 13:53
@RMcVelia RMcVelia force-pushed the 2166-scan-docker-image-in-all-repositories branch from 1f7df8e to 9cc9b14 Compare January 16, 2025 14:45
@saliceti saliceti merged commit a77ba9c into main Jan 17, 2025
12 checks passed
@saliceti saliceti deleted the 2166-scan-docker-image-in-all-repositories branch January 17, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saliceti saliceti saliceti approved these changes

Assignees
No one assigned
Labels
deploy DevOps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RMcVelia @saliceti