Update TeacherTrainingAdviserSignUp.cs

DFE-Digital · Jan 9, 2025 · 770af94 · 770af94
1 parent ce4e9c1
commit 770af94
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/GetIntoTeachingApi/Models/TeacherTrainingAdviser/TeacherTrainingAdviserSignUp.cs b/GetIntoTeachingApi/Models/TeacherTrainingAdviser/TeacherTrainingAdviserSignUp.cs
@@ -74,7 +74,6 @@ public enum ResubscribableAdviserStatus
         [SwaggerSchema(WriteOnly = true)]
         public int? CreationChannelActivityId { get; set; }
 
-
         public string Email { get; set; }
         public string FirstName { get; set; }
         public string LastName { get; set; }
@@ -259,16 +258,15 @@ private void ConfigureChannel(Candidate candidate)
         {
             if (CandidateId == null)
             {
-                if (CreationChannelSourceId.HasValue && CreationChannelServiceId.HasValue &&
-                    CreationChannelActivityId.HasValue)
+                if (CreationChannelSourceId.HasValue)
                 {
                     candidate.ChannelId = null;
                     candidate.ContactChannelCreations.Add(new ContactChannelCreation()
                     {
                         CreationChannel = true,
                         CreationChannelSourceId = CreationChannelSourceId.Value,
-                        CreationChannelServiceId = CreationChannelServiceId.Value,
-                        CreationChannelActivityId = CreationChannelActivityId.Value,
+                        CreationChannelServiceId = CreationChannelServiceId,
+                        CreationChannelActivityId = CreationChannelActivityId,
                     });
                 }
                 else
@@ -281,15 +279,14 @@ private void ConfigureChannel(Candidate candidate)
                 // NB: we do not update a candidate's ChannelId for an existing record
                 // NB: CreationChannel should be true only if it is the first ContactChannelCreation record
 
-                if (CreationChannelSourceId.HasValue && CreationChannelServiceId.HasValue &&
-                    CreationChannelActivityId.HasValue)
+                if (CreationChannelSourceId.HasValue)
                 {
                     candidate.ContactChannelCreations.Add(new ContactChannelCreation()
                     {
                         CreationChannel = !candidate.ContactChannelCreations.Any(),
                         CreationChannelSourceId = CreationChannelSourceId.Value,
-                        CreationChannelServiceId = CreationChannelServiceId.Value,
-                        CreationChannelActivityId = CreationChannelActivityId.Value,
+                        CreationChannelServiceId = CreationChannelServiceId,
+                        CreationChannelActivityId = CreationChannelActivityId,
                     });
                 }
             }