Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add creation channel model and TTA endppoint update #1494

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Add creation channel model and TTA endppoint update #1494

wants to merge 22 commits into from

Conversation

martyn-w
Copy link
Contributor

@martyn-w martyn-w commented Jan 7, 2025 •
edited
Loading

This adds the new Creation Channel model support to the TTA API, as well as being backwards-compatible for older API clients. Tested locally.

  • adds models for the Creation Channel Creation entity
  • adds picklist API endpoints for Creation Channel Services, Activities and Sources
  • adds optional parameters for the Teacher Training Adviser endpoint /api/teacher_training_adviser/candidates

https://trello.com/c/msbZBxnU/7073-update-git-api-to-support-new-creation-channel-structure-e11-gc3

@martyn-w martyn-w temporarily deployed to development_aks January 7, 2025 11:46 — with GitHub Actions Inactive
@github-actions github-actions bot added VisualCSharp Visual C # Test Test scripts and harnesses labels Jan 7, 2025
@martyn-w martyn-w changed the title Add creation channel model Add creation channel model and TTA endppoint update Jan 13, 2025
@martyn-w martyn-w marked this pull request as ready for review January 13, 2025 15:31
spanersoraferty
spanersoraferty previously approved these changes Jan 14, 2025
View reviewed changes
Copy link

@spanersoraferty spanersoraferty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments for completeness based on some of the stuff we've already chatted around but I'll approve given you've followed the existing patterns etc

GetIntoTeachingApi/Controllers/PickListItemsController.cs Show resolved Hide resolved
GetIntoTeachingApi/Models/Crm/Candidate.cs Show resolved Hide resolved
GetIntoTeachingApi/Models/Crm/ContactChannelCreation.cs Show resolved Hide resolved
GetIntoTeachingApi/Models/TeacherTrainingAdviser/TeacherTrainingAdviserSignUp.cs Outdated Show resolved Hide resolved
@martyn-w
Copy link
Contributor Author

DO NOT MERGE

until the CRM team have confirmed a bugfix for creating Contact Channel Creation records has been applied to the production CRM

martyn-w and others added 4 commits January 17, 2025 12:40
@martyn-w
add creation channels to remaining endpoints
8ab448e
@spencerohegartyDfE
Made changes to force code reuse and keep SonarQube happy
2702912
@spencerohegartyDfE
Removed ContactChannelCreations object which encapsulated list of Con…
2ae66ef 
…tactChannelCreation types given the attribute was masked from the underlying reflection property values extractor.
@martyn-w
Merge pull request #1496 from DFE-Digital/add-remaining-creation-chan…
72789e3 
…nel-endpoints

Add creation channels to remaining endpoints
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spanersoraferty spanersoraferty spanersoraferty left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Do Not Merge Test Test scripts and harnesses VisualCSharp Visual C #
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martyn-w @spanersoraferty @spencerohegartyDfE